bumper position and encoder holes #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increased the depth of the enconder holes on the bottom cases
|
Thank you! I ran into this issue, and had to snip the encoder legs. When I was modifying the case for my PR, I wanted to reduce the height, but never got around to it. |
azzamsa
reviewed
Jan 7, 2025
case/cheapino-bottom-right.scad
Outdated
| @@ -10,7 +10,7 @@ step = 0.05; | |||
| // 2.5 will leave 0.35 at the thinnest(between hotswap and magsafe). | |||
|
|
|||
|
|
|||
| $fn=$preview ? 50 : 50; | |||
| $fn=50; | |||
There was a problem hiding this comment.
Please use conditional. Take a look at https://github.com/tompi/cheapino/pull/118/files, as @tompi gives a green signal about this #72 (comment).
tompi
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bottom case changes:
I moved the bumper below the encoder to give more space for the encoder holes.
Increased the holes for the encoder to support the encoder pins better.