Periodically refresh ServiceAccount tokens #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomplus
reviewed
May 21, 2022
Periodically refresh ServiceAccount tokens. This is required to avoid authentication errors when time-bound tokens [1] are rotated, and the initially-read token expires. Time bound tokens are beta in Kubernetes 1.21, and GA in 1.22 [2]. [1]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/1205-bound-service-account-tokens [2]: kubernetes/enhancements#542
JacobHenner
force-pushed
the
feature/refresh-service-account-tokens
branch
from
b5fc07f to
f740775
Compare
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 27.39% 27.43% +0.03%
==========================================
Files 702 702
Lines 93973 94004 +31
==========================================
+ Hits 25748 25787 +39
+ Misses 68225 68217 -8
Continue to review full report at Codecov.
|
|
Rebased, requested changes made. |
tomplus
approved these changes
May 24, 2022
|
Thanks for your contribution. |
tomplus
pushed a commit
that referenced
this pull request
May 24, 2022
Periodically refresh ServiceAccount tokens. This is required to avoid authentication errors when time-bound tokens [1] are rotated, and the initially-read token expires. Time bound tokens are beta in Kubernetes 1.21, and GA in 1.22 [2]. [1]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/1205-bound-service-account-tokens [2]: kubernetes/enhancements#542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodically refresh ServiceAccount tokens. This is required to avoid
authentication errors when time-bound tokens 1 are rotated, and the
initially-read token expires. Time bound tokens are beta in Kubernetes
1.21, and GA in 1.22 2.