Move to collective? Also, fix svn switch handling. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives much better error reporting.
`.git` directory.
This addresses a few problems: 1. Trying to commit a git repo in a git repo is begging trouble 2. Repo formats my change across releases, using the tools to create repos at test runtime means the repos will have the right format 3. Makes much clearer what is supposed to be in the repo
Since the svn switch can leave things in an indeterminate state from git's perspective including more than just file changes but added and removed files and directories, we need to use "git checkout -f branch" to successfully change to the new branch. Also, the existing branches parsing was missing the current branch because it wasn't stripping the "*".
|
ross, i've added you as maintainer on PyPI, feel free to make a release, although i strongly would prefer if there'd be a test for your fix. i'm all for keeping this in the collective. |
|
Ok, well I can just work from a develop egg locally with the fix and wait to release until someone has time to add a test. Which would you prefer? Cut a release now or wait until someone has the time to add that test? |
|
fuck it, make a release :) |
|
Ugh, sorry Tom, I have username hell and I should have told you my username on PyPI is |
|
done |
|
...and done. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you like, we can just leave this in the collective, in which case you can ignore this pull request and just give me PyPI release rights. Otherwise, it would be great if you could merge this and cut a new release.
I've fixed svn switch handling and updated the tests. I've tested this locally and it works with a real-world code base with lots of refactoring changes between the branch and trunk.