This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
[DNM] replace moment w/ date-fns #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, that's about 2x the size of an uglified build of master: Destination: dist/opendata-chart-utils.min.js
Bundle size: 1.71 KB, Gzipped size: 755 B |
|
SIgh. Looks like, should we choose to merge this, we'll need this yarnpkg/yarn#1776 (comment) |
|
Closing this, as Open Data is hopelessly tied to moment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently inlining date-fns using rollup plugins.
Prob is that the source for the 3 functions we use from data-fns is 3x the size of the source of this repo:
> rollup -c profiles/dev.js src/index.js: date-fns - 15.48 KB (73.17%) app - 4.97 KB (23.49%) rollup helpers - 723 B (3.34%)I'm sure a lot of that is comments, etc, b/c the final output is reasonable:
Not totally convinced this is a better approach than treating moment as an external - only makes sense if we can get rid of moment in OD, and we don't end up using a whole bunch of date-fns in OD. Alternatively we could try to figure out how to use date-fns as an external.