W5 support added #16
Merged
W5 support added #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still WIP, don't merge |
Support External signer for wallet contracts 3,4,5
# Conflicts: # src/wallets/WalletContractV5.spec.ts # src/wallets/WalletContractV5.ts # src/wallets/signing/createWalletTransfer.ts # yarn.lock
dvlkv
requested changes
May 30, 2024
src/wallets/WalletContractV5.ts
Outdated
| this.walletId = walletId; | ||
|
|
||
| // Build initial code and data | ||
| let code = Cell.fromBoc(Buffer.from('te6cckEBAQEAIwAIQgLkzzsvTG1qYeoPK1RH0mZ4WyavNjfbLe7mvNGqgm80Eg3NjhE=', 'base64'))[0]; |
There was a problem hiding this comment.
Would be very nice if we specify a link for a commit from this code was built
src/wallets/WalletContractV5.ts
Outdated
| /** | ||
| * Sign and send request | ||
| */ | ||
| async sendRequest(provider: ContractProvider, args: Wallet5SendArgs & { actions: (OutActionSendMsg | OutActionExtended)[], }) { |
There was a problem hiding this comment.
what does Request actually mean? Maybe sendActionsBatch?
src/wallets/WalletContractV5.ts
Outdated
| /** | ||
| * Create signed request or extension auth request | ||
| */ | ||
| createRequest(args: Wallet5SendArgs & { actions: (OutActionSendMsg | OutActionExtended)[] }) { |
There was a problem hiding this comment.
Why do not create specific type for OutActions allowed for WalletV5? To avoid using union
yarn.lock
Outdated
| chalk: ^2.4.2 | ||
| checksum: d90981fdf56a2824a9b14d19a4c0e8db93633fd488c772624b4e83e0ceac6039a27cd298a247c3214faa952bf803ba23696172ae7e7235f3b97f43ba278c569a | ||
| checksum: 22e342c8077c8b77eeb11f554ecca2ba14153f707b85294fcf6070b6f6150aae88a7b7436dd88d8c9289970585f3fe5b9b941c5aa3aa26a6d5a8ef3f292da058 |
There was a problem hiding this comment.
Why yarn.lock is updated? There is no changes in package.json
(cherry picked from commit 3438c47)
…ignature_auth_allowed`
Get last master
|
@dvlkv Please check the updates, Wallet V5R1 is just supported |
dvlkv
approved these changes
Jul 16, 2024
src/wallets/WalletV5R1Utils.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * при экстернале обязателен флаг +2 в sendmode, при интернале - любой sendmode |
There was a problem hiding this comment.
Please, refrain from using languages other than English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.