improve typescript, added pnpm instead of yarn, updated dependencies, improved typescript config strictness #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… improved typescript config strictness
|
@dvlkv please review |
|
Hi! I am afraid I cannot merge this PR as it is affecting too much files and brings no practical value. Thank you for your contribution. |
|
@dvlkv It dos brings value: latest typescript, I've fixed some undefined or null type errors, updated types to support tsconfig settings. How is that not valuable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dvlkv Hello, please review. I found some issues - and fixed while improving the typescript config. Tried to impact as less as possible.
improve typescript, added pnpm instead of yarn, updated dependencies, improved typescript config strictness
Please review.