Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign >= and <= ligatures #231

Closed
jbellsey opened this issue Jul 26, 2016 · 1 comment
Closed

Redesign >= and <= ligatures #231

jbellsey opened this issue Jul 26, 2016 · 1 comment

Comments

@jbellsey
Copy link

Most of the ligatures are excellent at reducing noise, but these in particular are hard to read. The extra line is too tight to the angle:

image

I'd prefer either adding a bit more air between the angle and the "equals" line, or making the "equals" line horizontal (rather than angled). Either would let your brain process the symbol more easily.
@tonsky
Copy link
Owner

tonsky commented Jul 27, 2016

I fixed that in 1.200, please update

On Wed, Jul 27, 2016, 02:19 Jeff Bellsey [email protected] wrote:

Most of the ligatures are excellent at reducing noise, but these in
particular are hard to read. The extra line is too tight to the angle:

[image: image]
https://cloud.githubusercontent.com/assets/1831399/17152055/01a9936a-532b-11e6-88dd-3a662bf34109.png

I'd prefer either adding a bit more air between the angle and the "equals"
line, or making the "equals" line horizontal (rather than angled). Either
would let your brain process the symbol more easily.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#231, or mute the thread
https://github.com/notifications/unsubscribe-auth/AARabGh6_P9TkYUO5PIF4mNLskQ_g4Hlks5qZl3HgaJpZM4JVfle
.

Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
@dependabot-support
Merge tonsky#200
b0f078e 
200: Update rake requirement from ~> 10.0 to ~> 12.3 r=bronzdoc a=dependabot[bot]

Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
<details>
<summary>Changelog</summary>

*Sourced from [rake's changelog](https://github.com/ruby/rake/blob/master/History.rdoc).*

> === 12.3.1
> 
> ==== Bug fixes
> 
> * Support did_you_mean >= v1.2.0 which has a breaking change on formatters.
>   Pull request [tonsky#262](https://github-redirect.dependabot.com/ruby/rake/issues/262) by FUJI Goro.
> 
> ==== Enhancements:
> 
> * Don't run task if it depends on already invoked but failed task.
>   Pull request [tonsky#252](https://github-redirect.dependabot.com/ruby/rake/issues/252) by Gonzalo Rodriguez.
> * Make space trimming consistent for all task arguments.
>   Pull request [tonsky#259](https://github-redirect.dependabot.com/ruby/rake/issues/259) by Gonzalo Rodriguez.
> * Removes duplicated inclusion of Rake::DSL in tests.
>   Pull request [tonsky#254](https://github-redirect.dependabot.com/ruby/rake/issues/254) by Gonzalo Rodriguez.
> * Re-raise a LoadError that didn't come from require in the test loader.
>   Pull request [tonsky#250](https://github-redirect.dependabot.com/ruby/rake/issues/250) by Dylan Thacker-Smith.
> 
> === 12.3.0
> 
> ==== Compatibility Changes
> 
> * Bump `required_ruby_version` to Ruby 2.0.0. Rake has already
>   removed support for Ruby 1.9.x.
> 
> ==== Enhancements:
> 
> * Support `test-bundled-gems` task on ruby core.
> 
> === 12.2.1
> 
> ==== Bug fixes
> 
> * Fixed to break Capistrano::Application on capistrano3.
> 
> === 12.2.0
> 
> ==== Enhancements:
> 
> * Make rake easier to use as a library
>   Pull request [tonsky#211](https://github-redirect.dependabot.com/ruby/rake/issues/211) by [**drbrain**](https://github.com/drbrain)
> * Fix quadratic performance in FileTask#out_of_date?
>   Pull request [tonsky#224](https://github-redirect.dependabot.com/ruby/rake/issues/224) by [**doudou**](https://github.com/doudou)
> * Clarify output when printing nested exception traces
>   Pull request [tonsky#232](https://github-redirect.dependabot.com/ruby/rake/issues/232) by [**urbanautomaton**](https://github.com/urbanautomaton)
> 
> ==== Bug fixes
> 
> * Account for a file that match 2 or more patterns.
>   Pull request [tonsky#231](https://github-redirect.dependabot.com/ruby/rake/issues/231) by [**styd**](https://github.com/styd)
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- See full diff in [compare view](https://github.com/ruby/rake/commits/v12.3.1)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <[email protected]>
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
@dependabot-support
Merge tonsky#231
40d74c9 
231: Update rubocop requirement from = 0.67.1 to = 0.67.2 r=olleolleolle a=dependabot[bot]

Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
<details>
<summary>Release notes</summary>

*Sourced from [rubocop's releases](https://github.com/rubocop-hq/rubocop/releases).*

> ## RuboCop 0.67.2
> ### Bug fixes
> 
> * [#6882](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6882): Fix an error for `Rails/RedundantAllowNil` when not using both `allow_nil` and `allow_blank`. ([@&#8203;koic][])
> 
> [@&#8203;koic]: https://github.com/koic
</details>
<details>
<summary>Changelog</summary>

*Sourced from [rubocop's changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md).*

> ## 0.67.2 (2019-04-05)
> 
> ### Bug fixes
> 
> * [#6882](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6882): Fix an error for `Rails/RedundantAllowNil` when not using both `allow_nil` and `allow_blank`. ([@&#8203;koic][])
> 
> ## 0.67.1 (2019-04-04)
> 
> ### Changes
> 
> * [#6881](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6881): Set default `PreferredName` to `e` for `Naming/RescuedExceptionsVariableName`. ([@&#8203;koic][])
> 
> ## 0.67.0 (2019-04-04)
> 
> ### New features
> 
> * [#5184](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5184): Add new multiline element line break cops. ([@&#8203;maxh][])
> * Add new cop `Rails/ActiveRecordOverride` that checks for overriding Active Record methods instead of using callbacks. ([@&#8203;elebow][])
> * Add new cop `Rails/RedundantAllowNil` that checks for cases when `allow_blank` makes `allow_nil` unnecessary in model validations. ([@&#8203;elebow][])
> * Add new `Naming/RescuedExceptionsVariableName` cop. ([@&#8203;AdrienSldy][])
> 
> ### Bug fixes
> 
> * [#6761](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6761): Make `Naming/UncommunicativeMethodParamName` account for param names prefixed with underscores. ([@&#8203;thomthom][])
> * [#6855](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6855): Fix an exception in `Rails/RedundantReceiverInWithOptions` when the body is empty. ([@&#8203;ericsullivan][])
> * [#6856](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6856): Fix auto-correction for `Style/BlockComments` when the file is missing a trailing blank line. ([@&#8203;ericsullivan][])
> * [#6858](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6858): Fix an incorrect auto-correct for `Lint/ToJSON` when there are no `to_json` arguments. ([@&#8203;koic][])
> * [#6865](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6865): Fix deactivated `StyleGuideBaseURL` for `Layout/ClassStructure`. ([@&#8203;aeroastro][])
> * [#6868](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6868): Fix `Rails/LinkToBlank` auto-correct bug when using symbol for target. ([@&#8203;r7kamura][])
> * [#6869](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6869): Fix false positive for `Rails/LinkToBlank` when rel is a symbol value. ([@&#8203;r7kamura][])
> * Add `IncludedMacros` param to default rubocop config for `Style/MethodCallWithArgsParentheses`. ([@&#8203;maxh][])
> * [#6785](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6785): Do not register an offense for `Rails/Present` or `Rails/Blank` in an `unless else` context when `Style/UnlessElse` is enabled. ([@&#8203;rrosenblum][])
> 
> ### Changes
> 
> * [#6854](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6854): Mark Rails/LexicallyScopedActionFilter as unsafe and document risks. ([@&#8203;urbanautomaton][])
> * [#5977](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5977): Warn for Performance Cops. ([@&#8203;koic][])
> * [#6637](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6637): Move `LstripRstrip` from `Performance` to `Style` department and rename it to `Strip`. ([[@&#8203;anuja](https://github.com/anuja)-joshi][])
> * [#6875](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6875): Mention block form of `Struct.new` in ` Style/StructInheritance`. ([@&#8203;XrXr][])
> * [#6871](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6871): Move `Performance/RedundantSortBy`, `Performance/UnneededSort` and `Performance/Sample` to the Style department. ([@&#8203;bbatsov][])
> 
> ## 0.66.0 (2019-03-18)
> 
> ### New features
> 
> * [#6393](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6393): Add `AllowBracesOnProceduralOneLiners` option to fine-tune `Style/BlockDelimiter`'s semantic mode. ([@&#8203;davearonson][])
> * [#6383](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6383): Add `AllowBeforeTrailingComments` option on `Layout/ExtraSpacing` cop. ([@&#8203;davearonson][])
> * New cop `Lint/SafeNavigationWithEmpty` checks for `foo&.empty?` in conditionals. ([@&#8203;rspeicher][])
> * Add new `Style/ConstantVisibility` cop for enforcing visibility declarations of class and module constants. ([@&#8203;drenmi][])
> * [#6378](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6378): Add `Lint/ToJSON` cop to enforce an argument when overriding `#to_json`. ([@&#8203;allcentury][])
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`9c2950a`](rubocop/rubocop@9c2950a) Cut 0.67.2
- [`f7559c1`](rubocop/rubocop@f7559c1) Fix a typo
- [`a09f62b`](rubocop/rubocop@a09f62b) [Fix [#6882](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6882)] Fix an error for `Rails/RedundantAllowNil`
- See full diff in [compare view](rubocop/rubocop@v0.67.1...v0.67.2)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonsky @jbellsey