-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add matched files to output #24
Conversation
As my change is not breaking (it just adds) this is a feature increase in SemVer
LGTM and thank you for the contribution! Case: When the rule matched files are not modified, the value of the variable should be empty (right?). changed-file-filter/.github/workflows/test.yml Lines 27 to 28 in 970b98c
and here: Case: When the rule matched files are modified, the value should be a space-separated list of rule matched changed files. changed-file-filter/.github/workflows/test.yml Lines 52 to 53 in 970b98c
I realized it's not convenient to write tests in github action like that. I was thinking of moving the integration test cases from github workflow to jest if possible. So whether to add the tests in this PR is up to you, or you can leave it to me. |
Hi, I can indeed add tests in form of the test-workflow you posted. And yes testing GitHub actions is pain indeed and a problem i also didn't managed to solve |
Functionality applied in repo: https://github.com/nbrugger-tgm/java-spring-template/pull/16#issuecomment-962558123 |
Co-authored-by: Tony Duan <[email protected]>
Merged, Thank you! |
Gives the developer the option to use (or even iterate) over the list of changed files