Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys conversion from ed25519 (sign keys) to curve25519 (box keys) #42

Closed
wants to merge 2 commits into from

Conversation

blavenie
Copy link

@blavenie blavenie commented Apr 7, 2017

This pull request expose functions crypto_sign_ed25519_sk_to_curve25519 and crypto_sign_ed25519_pk_to_curve2551

(functions used an Unhosted JS application : Cesium)

@hoffmabc
Copy link

Bump?

@hoffmabc
Copy link

@tonyg is there any reason why this is being held up specifically?

@tonyg
Copy link
Owner

tonyg commented Nov 19, 2018

Hi! Sorry for the delay. No reason other than a lack of time.

Would you mind writing a few tests for the new functions, please? If possible, it'd be nice to lift the exact test cases from e.g. libsodium itself, to demonstrate the expected compatibility.

@catbref
Copy link

catbref commented May 20, 2019

The corresponding tests in libsodium are at:
https://github.com/jedisct1/libsodium/blob/master/test/default/ed25519_convert.c
and
https://github.com/jedisct1/libsodium/blob/master/test/default/ed25519_convert.exp

Really hope you can merge this and produce v1.3.3 as I'm having a horrible time of trying to build this myself.

@tonyg
Copy link
Owner

tonyg commented May 21, 2019

Thanks for those links, @catbref. The PR is missing tests and documentation; one good next step would be to take the tests you linked and write analogous js-nacl tests.

@catbref
Copy link

catbref commented May 30, 2019

Just to clarify, I couldn't modify this pull request so reworked the changes against latest master branch, added tests and created new pull request #54

Hopefully you can merge in #54 and close this one?

@blavenie
Copy link
Author

blavenie commented Dec 20, 2019

Close. A more recent PR (with tests) exists : #54

@blavenie blavenie closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants