Use dprint for formatting #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eritbh
added
code quality
meta
ashen-dawn
suggested changes
Aug 17, 2023
ashen-dawn
approved these changes
Aug 17, 2023
eritbh
added a commit
that referenced
this pull request
Aug 18, 2023
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #784. Sets us up to use
dprintfor formatting the project. Removes formatting-specific eslint rules.I lean towards using
dprintisntead ofprettierfor formatting because it's more configurable and lets us maintain a style relatively similar to what we already have. This PR touches lots of files, but the only things that are really super different are line wrapping behaviors in certain areas and disallowing declaring multiple variables in a singlelet/conststatement. It also has much more sane formatting for complex multiline ternary expressions thanprettier.dprintuses the same set of rules for formatting both Javascript and Typescript, and also does formatting for JSON and Markdown files.I'll need to re-enable non-squash merges for this repo before I merge this - the PR adds a
.git-blame-ignore-revsfile with commit hashes of specific commits in this PR, so those commits need to not be squashed when merging for it to work correctly.