This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Parse HTML on main thread #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 9, 2019
| return self.getAttributedTextFromDown(with: input) | ||
| } | ||
|
|
||
| var output = NSAttributedString(string: input) |
There was a problem hiding this comment.
No need to convert input to a NSAttributedString, it will be replaced with the return value of getAttributedTextFromDown anyway.
There was a problem hiding this comment.
This is just a way to initialize output as a non-optional NSAttributedString, but yes I will replace with an empty string.
Current coverage for RichTextView.framework is
|
| Files changed | - | - |
|---|---|---|
| RichTextParser.swift | 94.26% |
✅ |
Powered by xcov
Generated by 🚫 Danger
|
Just an FYI, this will be much faster if you use the new AST renderer in v0.7.0 and above. See johnxnguyen/Down#132 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround for johnxnguyen/Down#116
DevQA
DevQA Prep
pod installRichTextViewto ensure that it passes (unit and UI tests)Exampleproject in the rootExamplefolder and run the appExampleapp looks visually correct