Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kubebuilder project to v4 (2) #100

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Migrate kubebuilder project to v4 (2) #100

merged 2 commits into from
Jan 12, 2024

Conversation

llamerada-jp
Copy link
Contributor

related: #79

  • move e2e dir to under test dir since v4 template made test/e2e
  • remove unsed manifest on config dir

@llamerada-jp llamerada-jp requested a review from a team as a code owner January 11, 2024 02:46
toshipp
toshipp previously approved these changes Jan 11, 2024
View reviewed changes
peng225
peng225 reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@peng225 peng225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the .dockerinore, too.

pie/.dockerignore

Line 8 in 6cef66c

e2e/

@llamerada-jp llamerada-jp force-pushed the kubebuilder-project-v4-2 branch from c7034c1 to 1d3d7ee Compare January 12, 2024 06:15
@llamerada-jp
Copy link
Contributor Author

Please change the .dockerinore, too.

pie/.dockerignore

Line 8 in 6cef66c

e2e/

refrected

https://github.com/topolvm/pie/compare/c7034c1cac96b92c37b827a9ed0c40ac06b65b4f..1d3d7eea38f19cb00bb8a8e12d4b0316b068b669

@llamerada-jp llamerada-jp requested a review from peng225 January 12, 2024 06:16
@llamerada-jp llamerada-jp merged commit 1cb078c into main Jan 12, 2024
6 checks passed
@llamerada-jp llamerada-jp deleted the kubebuilder-project-v4-2 branch January 12, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peng225 peng225 peng225 approved these changes

@toshipp toshipp toshipp left review comments

Assignees
No one assigned
Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llamerada-jp @toshipp @peng225