fix: use at most 15 letters for node name in cronjob name #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the current implementation decides a cronjob name, it uses at most 11 letters for a node name. This behavior is problematic when a node name is an IP address, because it can have at most 15 (= 3*4+3) letters. This commit fixes this problem by including at most 15 letters of the node name in the cronjob name. In compensation, this commit shrinks the length of the storage class name to 12. A mount cronjob name (at most 40 letters) consists of: - "provision-" (10 letters) - PieProbe resource name (at most 10 letters) - hyphen (1 letter) - StorageClass name (at most 12 letters) - hyphen (1 letter) - hash (6 letters) A provision cronjob name (at most 52 letters) consists of: - "mount-" (6 letters) - PieProbe resource name (at most 10 letters) - hyphen (1 letter) - Node name (at most 15 letters) - hyphen (1 letter) - StorageClass name (at most 12 letters) - hyphen (1 letter) - hash (6 letters) Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
force-pushed
the
fix-cronjob-name
branch
from
99c9bde to
4dee32a
Compare
pluser
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the current implementation decides on a cronjob name, it uses at most 11 letters for a node name. This behaviour is problematic when a node name is an IP address, which can be at most 15 (= 3*4+3) letters. This commit fixes this problem by including at most 15 letters of the node name in the cronjob name. In compensation, this commit shrinks the length of the storage class name from 14 to 12.
A mount cronjob name (at most 40 letters) consists of:
A provision cronjob name (at most 52 letters) consists of: