adding annotations to the deployment #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshipp
previously approved these changes
Aug 19, 2024
|
@ekirmayer Could you update your code so that the CI can pass? It looks like you need to run |
|
@ushitora-anqou i see that there are two failing test on connectivity but i cant re-trigger the action. Is it something i need to fix? |
|
I don't think you need to fix anything. Actually, the e2e tests are kind of flaky. I'll retry them. |
|
This flakiness is consistently happened on CI. I'll try to solve it. |
|
@ekirmayer |
Signed-off-by: Kirmayer Elad <[email protected]>
|
Still failing... I'll dig into it more. |
|
I retried and CI passed. I suspect the flakiness may still exist, but we can proceed. |
toshipp
approved these changes
Aug 26, 2024
ushitora-anqou
approved these changes
Aug 26, 2024
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow passing annotations at the deployment level. Allow supporting controllers which use the deployment annotations.