Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pagination component #35

Merged
merged 3 commits into from
Jan 25, 2019
Merged

Conversation

bytasv
Copy link
Contributor

@bytasv bytasv commented Jan 24, 2019

PICAS-36

Screenshots

image

image

Let's discuss the API aswell

@bytasv bytasv added the Feature New feature or request label Jan 24, 2019
@bytasv bytasv self-assigned this Jan 24, 2019
@bytasv bytasv requested a review from a team January 24, 2019 15:39
@bytasv bytasv force-pushed the picas-36-initial-components-pagination branch from e51eb44 to a627ba5 Compare January 24, 2019 15:40
components/Pagination/Pagination.jsx Outdated Show resolved Hide resolved
components/Pagination/Pagination.jsx Outdated Show resolved Hide resolved
components/Pagination/styles.js Outdated Show resolved Hide resolved
@denieler
Copy link
Collaborator

btw, we should fix this:
screenshot 2019-01-25 at 10 11 26

@bytasv have you mentioned it in the card you've created for Buttons?

@bytasv
Copy link
Contributor Author

bytasv commented Jan 25, 2019

btw, we should fix this:
screenshot 2019-01-25 at 10 11 26

@bytasv have you mentioned it in the card you've created for Buttons?

Added this to the ticket, thanks

Copy link
Collaborator

@denieler denieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

components/Pagination/Pagination.jsx Show resolved Hide resolved
components/Pagination/styles.js Outdated Show resolved Hide resolved
@bytasv bytasv merged commit 38c72bf into master Jan 25, 2019
@bytasv bytasv deleted the picas-36-initial-components-pagination branch January 25, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants