Skip to content

Commit

Permalink
docs: move comment
Browse files Browse the repository at this point in the history
  • Loading branch information
josecelano committed Feb 9, 2024
1 parent a8c2f84 commit 564df07
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 0 additions & 2 deletions src/web/api/client/v1/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ impl Client {
///
/// Will panic if the request fails.
pub async fn get_tags(&self) -> TextResponse {
// code-review: some endpoint are using plural
// (for instance, `get_categories`) and some singular.
self.http_client.get("/tags", Query::empty()).await.unwrap()
}

Expand Down
1 change: 1 addition & 0 deletions src/web/api/server/v1/routes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ pub const API_VERSION_URL_PREFIX: &str = "v1";
#[allow(clippy::needless_pass_by_value)]
pub fn router(app_data: Arc<AppData>) -> Router {
// code-review: should we use plural for the resource prefix: `users`, `categories`, `tags`?
// Some endpoint are using plural (for instance, `get_categories`) and some singular.
// See: https://stackoverflow.com/questions/6845772/should-i-use-singular-or-plural-name-convention-for-rest-resources

let v1_api_routes = Router::new()
Expand Down

0 comments on commit 564df07

Please sign in to comment.