-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker Checker (UDP): Don't stop on the first fail #1040
Comments
I've noticed here that it is using torrust-tracker/src/console/clients/checker/service.rs Lines 52 to 54 in cb9e345
I wouldn't mind looking more into this issue. Result<T, JoinError> and just passing results instead of results? ; could look similar to this StackOverflow answer.A dirty fix perhaps, but having an Option<JoinError> as some sort of flag whether the join errored could be an option. This lets us continue the while loop without exiting.
|
Replacing the above with while let Some(results) = checks.join_next().await {
match results {
Ok(mut r) => check_results.append(&mut r),
Err(_) => (),
};
} Produces an identical output. Means it probably wasn't the issue of |
Hi @abstralexis, I need some time to review that part of the code because it was done by @da2ce7 and I don't know it. That error comes from the |
Thanks - I traced where perhaps the error would end up if being sent from there during checks - should these torrust-tracker/src/console/clients/checker/checks/udp.rs Lines 45 to 70 in cb9e345
I think these would be causing the loop to exit completely, rather than check the next one. I will try to confirm later. |
Yep, I believe this was it. I now get:
Will submit a PR. |
a34f66e Fix #1040: `continue` when finding errors (abstralexis) Pull request description: Fix the behaviour of UDP checks exiting on first fail (#1040). Was `break`ing instead of `continue`ing when iterating over each test. ACKs for top commit: josecelano: ACK a34f66e Tree-SHA512: 616c5671f2e6912fb7992794ca634d1402e7d4e712a5dbb5dab498ac67bbf622220f241d84f8ebc3129ba284dca587040a5cca2989023979d2068e458e5382e1
Parent issue: #669
When you run the checker for multiple UDP trackers, it stops when the first tracker check fails.
How to reproduce
Run the checker without running the tracker:
The text was updated successfully, but these errors were encountered: