Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axum HTTP tracker: discarded PR #179

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Axum HTTP tracker: discarded PR #179

merged 4 commits into from
Feb 9, 2023

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Feb 6, 2023 •
edited
Loading

This PR is a discarded parent PR. We are tracking subtasks for issue #160 within the issue instead of here.

UPDATE: 12/02/2023

@josecelano josecelano force-pushed the issue-160-http-tracker-with-axum branch from 7375223 to 849633d Compare February 6, 2023 15:44
@josecelano josecelano linked an issue Feb 6, 2023 that may be closed by this pull request
Reimplement the current HTTP tracker using Axum #160
Closed
17 tasks
@josecelano josecelano force-pushed the issue-160-http-tracker-with-axum branch from 6b57dfd to 13a4982 Compare February 7, 2023 10:10
@josecelano
Copy link
Member Author

josecelano commented Feb 7, 2023 •
edited
Loading

hi @da2ce7 @WarmBeer, since this PR could be too big, I'm working so that it can be merged at any time. If you want, you can review what I've done so far, and I will merge it. I will reopen it later to continue working on the next subtasks.

Right now, both implementations can be executed for testing. The scaffolding for Axum is ready, and I will start implementing endpoints.

@josecelano
feat(http): [torrust#160] scaffolding for HTTP tracker using Axum
0dc3050 
We are going to migrate the HTTP tracker from Warp to Axum.
This is the basic scaffolding for Axum. Tests have been duplicated to
test the new Axum implementation. The setup allows executing both
versions: the Warp version on production and both versions (Warp and
Axum) on testing env.
@josecelano josecelano added the Needs Rebase Base Branch has Incompatibilities label Feb 8, 2023
@josecelano josecelano force-pushed the issue-160-http-tracker-with-axum branch from 13a4982 to b82fb75 Compare February 8, 2023 08:43
@da2ce7 da2ce7 removed the Needs Rebase Base Branch has Incompatibilities label Feb 8, 2023
@josecelano josecelano force-pushed the issue-160-http-tracker-with-axum branch from b82fb75 to cffd071 Compare February 8, 2023 09:48
@da2ce7
Copy link
Contributor

da2ce7 commented Feb 8, 2023

If you wish to part-wise merge this pull request, split out the current work into a new dedicated pull request, then you can merge that one while keeping this pull request open.

@josecelano josecelano force-pushed the issue-160-http-tracker-with-axum branch from cffd071 to 2f62e8c Compare February 9, 2023 09:34
@josecelano
feat(http): [torrust#160] Axum extractor to extract announce request …
9c25feb 
…params from url query

WIP: only for mandatory params.
@josecelano josecelano force-pushed the issue-160-http-tracker-with-axum branch from 2f62e8c to 9c25feb Compare February 9, 2023 09:35
@josecelano
refactor(http): [torrust#160] reorganize dirs for Axum and Warp HTTP …
995397e 
…tracker implementations

We are going to start sharing code bettween both implementation (Warp
and Axum). We need to keep common code separated because Warp
implementation will be removed when Axum implementation is finished.
@josecelano josecelano marked this pull request as draft February 9, 2023 13:01
@josecelano josecelano mentioned this pull request Feb 9, 2023
Merged
@josecelano
Copy link
Member Author

If you wish to part-wise merge this pull request, split out the current work into a new dedicated pull request, then you can merge that one while keeping this pull request open.

hi @da2ce7 @WarmBeer, I've created the new child PR. I will keep this for tracking the implementation of the main issue, but I will create a new PR for each subtask.

@josecelano josecelano merged commit 8e85f18 into torrust:develop Feb 9, 2023
@josecelano josecelano deleted the issue-160-http-tracker-with-axum branch February 9, 2023 13:47
@josecelano josecelano mentioned this pull request Feb 10, 2023
Merged
@da2ce7
Copy link
Contributor

da2ce7 commented Feb 10, 2023

@josecelano This pull request was automatically merged when we merged #180, it is impossible to reopen, we should make a new parent pull-request.

@josecelano
Copy link
Member Author

josecelano commented Feb 10, 2023 •
edited
Loading

@josecelano This pull request was automatically merged when we merged #180, it is impossible to reopen, we should make a new parent pull-request.

Since I'm planning to merge child PRs into develop, maybe we could just move the description to the issue. In the end we are using this PR only to track the progress on the main issue. What do you think @da2ce7 ?

It would be different if we were using stacked PRs.

@josecelano josecelano mentioned this pull request Feb 12, 2023
Closed
17 tasks
@josecelano josecelano changed the title Reimplement the HTTP tracker using Axum Axum HTTP tracker: basic scaffolding Feb 12, 2023
@josecelano
Copy link
Member Author

I've moved the subtask in this PR description to the issue

@josecelano josecelano removed a link to an issue Feb 12, 2023
Reimplement the current HTTP tracker using Axum #160
Closed
17 tasks
@josecelano josecelano changed the title Axum HTTP tracker: basic scaffolding Axum HTTP tracker: discarded PR Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

@mickvandijke mickvandijke Awaiting requested review from mickvandijke

Assignees
No one assigned
Labels
None yet
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josecelano @da2ce7