-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axum HTTP tracker: scrape
response in public mode
#192
Merged
josecelano
merged 9 commits into
torrust:develop
from
josecelano:issue-191-axum-http-tracker-scrape-req-public-mode
Feb 27, 2023
Merged
Axum HTTP tracker: scrape
response in public mode
#192
josecelano
merged 9 commits into
torrust:develop
from
josecelano:issue-191-axum-http-tracker-scrape-req-public-mode
Feb 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xum HTTP tracker with only one infohash in the URL: http://localhost:7070/scrape?info_hash=%3B%24U%04%CF%5F%11%BB%DB%E1%20%1C%EAjk%F4Z%EE%1B%C0 It does not allow more than one infohas yet.
THat dependency will be use to store URL query param in a MultiMap struct, becuase query params can have multiple values like this: ``` param1=value1¶m1=value2 ``` The multimaps allows to add multiple values to a HashMap.
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this pull request
Feb 23, 2023
… same param The `torrust_tracker::http::axum_implementation::query` allow mutiple values for the same URL query param, for example: ``` param1=value1¶m2=value2 ``` It's needed in the `scrape` request: http://localhost:7070/scrape?info_hash=%3B%24U%04%CF%5F%11%BB%DB%E1%20%1C%EAjk%F4Z%EE%1B%C0&info_hash=%3B%24U%04%CF%5F%11%BB%DB%E1%20%1C%EAjk%F4Z%EE%1B%C0
… same param The `torrust_tracker::http::axum_implementation::query` allow mutiple values for the same URL query param, for example: ``` param1=value1¶m2=value2 ``` It's needed in the `scrape` request: http://localhost:7070/scrape?info_hash=%3B%24U%04%CF%5F%11%BB%DB%E1%20%1C%EAjk%F4Z%EE%1B%C0&info_hash=%3B%24U%04%CF%5F%11%BB%DB%E1%20%1C%EAjk%F4Z%EE%1B%C0
6b8c8bf
to
0c7735a
Compare
This function returns the data we need for a scrape response regardless the method that the client is using to communicate with the tracker (UDP or HTTP).
3a1285c
to
ae1a076
Compare
josecelano
added a commit
to josecelano/torrust-tracker
that referenced
this pull request
Feb 27, 2023
43ab216
to
86ce93c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrape
request in the new Axum HTTP tracker implementation. Only porpublic
mode.