Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication in HTTP announce response #585

Conversation

josecelano
Copy link
Member

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5f6eed7) 80.68% compared to head (759594a) 80.76%.

Files Patch % Lines
src/servers/http/v1/responses/announce.rs 83.67% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #585      +/-   ##
===========================================
+ Coverage    80.68%   80.76%   +0.08%     
===========================================
  Files          117      117              
  Lines         7816     7824       +8     
===========================================
+ Hits          6306     6319      +13     
+ Misses        1510     1505       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano
Copy link
Member Author

ACK 759594a

@da2ce7
Copy link
Contributor

da2ce7 commented Jan 8, 2024

@josecelano

I've reviewed this version, and it dose not remove much of the duplication that my version removes. Although I prefer your Policy and SwarmStats structs.

I will rebase my implementation based upon f9fff63

:)

@josecelano
Copy link
Member Author

@josecelano

I've reviewed this version, and it dose not remove much of the duplication that my version removes. Although I prefer your Policy and SwarmStats structs.

I will rebase my implementation based upon f9fff63

:)

Close in favor of #563.

@josecelano josecelano closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants