-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplication in HTTP announce response #585
Remove duplication in HTTP announce response #585
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #585 +/- ##
===========================================
+ Coverage 80.68% 80.76% +0.08%
===========================================
Files 117 117
Lines 7816 7824 +8
===========================================
+ Hits 6306 6319 +13
+ Misses 1510 1505 -5 ☔ View full report in Codecov by Sentry. |
ACK 759594a |
I've reviewed this version, and it dose not remove much of the duplication that my version removes. Although I prefer your I will rebase my implementation based upon f9fff63 :) |
Hi @da2ce7, this is an alternative for removing duplication from the HTTP announce response.