Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: Improve E2E tests runner #648

Merged
merged 6 commits into from
Jan 26, 2024
Merged

E2E tests: Improve E2E tests runner #648

merged 6 commits into from
Jan 26, 2024

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jan 26, 2024 •
edited
Loading

  • Check that we run all services (UDP, HTTP, HealCheck API).
  • Check that the logs don't contain any panics.

@josecelano
refactor: [torrust#647] extract strcut RunOptions
0afab09
@josecelano
ci: [torrust#647] E2E tests. Make sure we run at least one service pe…
670927c 
…r type

We want to run all services in the E2E tests env. At least one running
service per type:

- HTTP tracker
- UDP tracker
- HealthCheck endpoint
@josecelano josecelano self-assigned this Jan 26, 2024
@josecelano josecelano added the Testing Checking Torrust label Jan 26, 2024
@josecelano josecelano linked an issue Jan 26, 2024 that may be closed by this pull request
E2E tests: Improve E2E test runner #647
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (14f88e9) 75.99% compared to head (f18e68c) 75.22%.

Files Patch % Lines
src/e2e/tracker_container.rs 0.00% 69 Missing ⚠️
src/e2e/runner.rs 0.00% 36 Missing ⚠️
src/e2e/docker.rs 0.00% 28 Missing ⚠️
src/checker/service.rs 0.00% 5 Missing ⚠️
src/checker/app.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #648      +/-   ##
===========================================
- Coverage    75.99%   75.22%   -0.78%     
===========================================
  Files          135      136       +1     
  Lines         8791     8881      +90     
===========================================
  Hits          6681     6681              
- Misses        2110     2200      +90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano added this to the v3.0.0 milestone Jan 26, 2024
@josecelano josecelano marked this pull request as ready for review January 26, 2024 16:28
@josecelano
fix: tracker checker return error code when it fails
f18e68c 
This command:

```
cargo run --bin tracker_checker "./share/default/config/tracker_checker.json" && echo "OK"
```

should not print OK when it fails.
@josecelano josecelano force-pushed the 647-improve-e2e-test-runner branch from 2ddc0ba to f18e68c Compare January 26, 2024 16:29
@josecelano
Copy link
Member Author

ACK f18e68c

@josecelano josecelano merged commit 0f573b6 into torrust:develop Jan 26, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

@mickvandijke mickvandijke Awaiting requested review from mickvandijke

Assignees

@josecelano josecelano

Labels
Testing Checking Torrust
Projects
Torrust Solution
Status: No status
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

E2E tests: Improve E2E test runner
1 participant
@josecelano