Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: reorganize modules for console commands #662

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Refactor: reorganize modules for console commands #662

merged 4 commits into from
Jan 30, 2024

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jan 30, 2024 •
edited
Loading

Refactor: reorganize modules for console commands

  • Move E2E tests runner.
  • Move Tracker Checker.
  • Move HTTP Tracker client.
  • Move UDP Tracker client.

@josecelano josecelano self-assigned this Jan 30, 2024
@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 30, 2024
@josecelano josecelano added this to the v3.0.0 milestone Jan 30, 2024
@josecelano josecelano linked an issue Jan 30, 2024 that may be closed by this pull request
Refactor: reorganize modules for console commands #661
Closed
@josecelano josecelano requested a review from da2ce7 January 30, 2024 10:20
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (5b6cf7b) 74.81% compared to head (47551ff) 73.77%.

Files Patch % Lines
src/console/clients/udp/app.rs 0.00% 72 Missing ⚠️
src/console/clients/http/app.rs 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #662      +/-   ##
===========================================
- Coverage    74.81%   73.77%   -1.05%     
===========================================
  Files          136      138       +2     
  Lines         8930     9056     +126     
===========================================
  Hits          6681     6681              
- Misses        2249     2375     +126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 661-refactor-reorganize-modules-for-console-commands branch from 796cbc7 to 47551ff Compare January 30, 2024 12:41
@josecelano
Copy link
Member Author

ACK 47551ff

@josecelano josecelano marked this pull request as ready for review January 30, 2024 12:41
@josecelano josecelano merged commit 005a8cf into torrust:develop Jan 30, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
Torrust Solution
Status: No status
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Refactor: reorganize modules for console commands
1 participant
@josecelano