Torrent repository with parking_lot
crate locks
#800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #774
A new torrent repository implementation with a different lock implementation for the torrent entry.
The crate is: parking_lot
It's supposed to be faster than the standard implementation of
Mutex
andRwLock
.This PR adds two implementations with
Mutex
andRwLock
.Subtasks
parking_lot::RwLock
parking_lot::Mutex
Performance
With
parking_lot::RwLock
:With
parking_lot::RwLock::Mutex
With current implementation (SkipMap and Std Mutex):
Conclusion
Performance looks similar (the current version is slightly better), so I would keep the current version with the standard Mutex.