Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: tracker core service only needs the core config #857

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented May 10, 2024

Relates to: #401

After extracting the Core config type, we don't need to pass the whole configuration to the tracker core service. We can pass only its config.

@josecelano josecelano requested a review from da2ce7 May 10, 2024 16:07
@josecelano josecelano force-pushed the refactor-inject-only-core-config-to-tracker branch from abf79e8 to 0b857eb Compare May 10, 2024 16:08
@josecelano josecelano force-pushed the refactor-inject-only-core-config-to-tracker branch from 0b857eb to 80e691b Compare May 10, 2024 16:09
@josecelano josecelano force-pushed the refactor-inject-only-core-config-to-tracker branch from 80e691b to ae77ebc Compare May 10, 2024 16:09
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.83%. Comparing base (014ca38) to head (ae77ebc).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #857      +/-   ##
===========================================
+ Coverage    78.75%   78.83%   +0.07%     
===========================================
  Files          169      169              
  Lines         9293     9341      +48     
===========================================
+ Hits          7319     7364      +45     
- Misses        1974     1977       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano
Copy link
Member Author

ACK ae77ebc

@josecelano josecelano merged commit 3c78bba into torrust:develop May 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant