Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improved bootstrap jobs module test. #875

Merged
merged 1 commit into from
May 20, 2024

Conversation

GGLinnk
Copy link
Contributor

@GGLinnk GGLinnk commented May 20, 2024

On non-English operating systems, the source BadTlsConfig error message will be different from the compared message.
This solves the problem by matching the enumeration itself, rather than relying on a string comparison.

@GGLinnk GGLinnk force-pushed the 2024-05-20-fix-bs-jobs-mod-test branch from fc82bb8 to 10a1995 Compare May 20, 2024 16:48
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.83%. Comparing base (5478c3d) to head (9be9366).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #875      +/-   ##
===========================================
- Coverage    78.88%   78.83%   -0.05%     
===========================================
  Files          170      170              
  Lines         9395     9394       -1     
===========================================
- Hits          7411     7406       -5     
- Misses        1984     1988       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GGLinnk GGLinnk force-pushed the 2024-05-20-fix-bs-jobs-mod-test branch from 10a1995 to 3730c73 Compare May 20, 2024 17:08
@josecelano josecelano self-assigned this May 20, 2024
On O.S. with different language than english the BadTlsConfig source error message will differ from the compared one.
This will fix this issue by matching the enum itself instead of relying on a string compare.
@josecelano josecelano added the Testing Checking Torrust label May 20, 2024
@GGLinnk GGLinnk force-pushed the 2024-05-20-fix-bs-jobs-mod-test branch from 3730c73 to 9be9366 Compare May 20, 2024 17:25
@GGLinnk
Copy link
Contributor Author

GGLinnk commented May 20, 2024

Sorry for all the force push, I try to pass as many tests as possible.

Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GGLinnk!

@josecelano josecelano self-requested a review May 20, 2024 17:43
@josecelano
Copy link
Member

ACK 9be9366

@josecelano josecelano merged commit d4eaea9 into torrust:develop May 20, 2024
17 checks passed
@GGLinnk
Copy link
Contributor Author

GGLinnk commented May 20, 2024

Additional note @josecelano :

The project currently seems to work perfectly under Windows.
If so, should I update the README accordingly?

@GGLinnk GGLinnk deleted the 2024-05-20-fix-bs-jobs-mod-test branch May 20, 2024 18:04
@josecelano
Copy link
Member

josecelano commented May 20, 2024

Additional note @josecelano :

The project currently seems to work perfectly under Windows. If so, should I update the README accordingly?

Hi, have you seen this #325. To be honest, I have not tried to compile in Windows yet. If it's working, I would:

  • Close Torrust-Tracker won't compile on Windows #325 updating the README as you propose.
  • Execute the testing workflow with Ubuntu and Windows, if possible. If it's not possible, I would add a new workflow just to check that the application compiles in Windows.

UPDATE: we could try with https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#using-a-matrix-strategy

jobs:
  example_matrix:
    strategy:
      matrix:
        version: [10, 12, 14]
        os: [ubuntu-latest, windows-latest]

@GGLinnk
Copy link
Contributor Author

GGLinnk commented May 20, 2024

@josecelano

It' seems that 5 unit test are failing under windows.
I'll investigate. I'll will continue this conversation in #325 if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Checking Torrust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants