Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from log to tracing crate #888

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Move from log to tracing crate #888

merged 6 commits into from
Jun 10, 2024

Conversation

josecelano
Copy link
Member

Move from log to tracing crate.

@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat Dependencies Related to Dependencies labels Jun 10, 2024
@josecelano josecelano added this to the v3.0.0 milestone Jun 10, 2024
@josecelano josecelano linked an issue Jun 10, 2024 that may be closed by this pull request
Move from log to tracing crate #884
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.15385% with 41 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (613a1df) to head (ec88dbf).

Files Patch % Lines
src/bootstrap/logging.rs 10.00% 27 Missing ⚠️
src/console/ci/e2e/runner.rs 0.00% 5 Missing ⚠️
src/console/clients/checker/app.rs 0.00% 3 Missing ⚠️
src/console/clients/udp/app.rs 0.00% 3 Missing ⚠️
packages/configuration/src/lib.rs 0.00% 1 Missing ⚠️
src/console/ci/e2e/docker.rs 0.00% 1 Missing ⚠️
src/console/ci/e2e/tracker_container.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #888      +/-   ##
===========================================
+ Coverage    78.54%   78.60%   +0.05%     
===========================================
  Files          171      171              
  Lines         9434     9431       -3     
===========================================
+ Hits          7410     7413       +3     
+ Misses        2024     2018       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano
test: [torrust#884] add test for parsing array of services from app logs
d6fd11a 
The tracker can run multiple UDP or HTTP trackers. We parse the services
from app output but there was not test for multiple services of the same
type (UDP or HTTP tracker).
@josecelano
chore(deps): remove unused dependencies log and fern
ec88dbf 
We have moved from crate log to tracing.
@josecelano josecelano force-pushed the 884-move-from-log-to-tracing-crate branch from 014bda6 to ec88dbf Compare June 10, 2024 16:24
@josecelano
Copy link
Member Author

ACK ec88dbf

@josecelano josecelano self-assigned this Jun 10, 2024
@josecelano josecelano marked this pull request as ready for review June 10, 2024 16:54
@josecelano josecelano requested a review from da2ce7 June 10, 2024 16:55
@josecelano josecelano merged commit dc171c1 into torrust:develop Jun 10, 2024
16 of 17 checks passed
This was referenced Jun 10, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels
Code Cleanup / Refactoring Tidying and Making Neat Dependencies Related to Dependencies
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Move from log to tracing crate
1 participant
@josecelano