-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: apply future type hints style #1884
base: develop
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #1884 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 13408107803Details
💛 - Coveralls |
@henadzit Cloud you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, i reviewed probably a half of this PR and left a few comments. Hopefully, I'll check out the other half in the coming days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments but apart from that I think it's good to go!
Description
from __future__ import annotations
:ruff check --fix --unsafe-fixes tortoise examples tests conftest.py
to reformatautoflake --remove-all-unused-imports -i -r tortoise examples tests conftest.py
make _style
make lint
to bemake style
+make check
tortoise/backends/base/schema_generator.py::BaseSchemaGenerator::_get_table_sql
to reduce complexity (which was complained by codacy)Motivation and Context
To improve contributing experience
How Has This Been Tested?
make ci
Checklist: