Fix rebuild with new controller #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rebuilding SplitView with an inline-constructed controller, the new controller was not assigned to `_SplitViewState._controller` and thus, did not get notified of moves after the first rebuild. Fixes: #19
This was referenced Aug 11, 2022
Closed
|
@jpnurmi |
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Aug 12, 2022
The blocker issue in the retracted 3.2.0 version was fixed by toshiaki-h/split_view#20. Close: canonical#1031
jpnurmi
added a commit
to canonical/ubuntu-desktop-installer
that referenced
this pull request
Aug 12, 2022
The blocker issue in the retracted 3.2.0 version was fixed by toshiaki-h/split_view#20. Close: #1031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rebuilding SplitView with an inline-constructed controller, the new
controller was not assigned to
_SplitViewState._controllerand thus,did not get notified of moves after the first rebuild.
Fixes: #19