Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unzipWith): add unzipWith #113

Merged
merged 13 commits into from
Jul 3, 2024
Merged

feat(unzipWith): add unzipWith #113

merged 13 commits into from
Jul 3, 2024

Conversation

po4tion
Copy link
Contributor

@po4tion po4tion commented Jul 2, 2024

close #90

I created an unzipWith function according to the requirements of the issue.

스크린샷 2024-07-02 오후 11 43 39

@po4tion po4tion requested a review from raon0211 as a code owner July 2, 2024 14:49
Copy link

vercel bot commented Jul 2, 2024

@po4tion is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c1d80ff) to head (22e5955).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        62    +1     
  Lines          329       338    +9     
  Branches        39        39           
=========================================
+ Hits           329       338    +9     

Copy link

codspeed-hq bot commented Jul 2, 2024

CodSpeed Performance Report

Merging #113 will degrade performances by 88.51%

Comparing po4tion:feat/unzipWith (22e5955) with po4tion:feat/unzipWith (436552d)

Summary

⚡ 4 improvements
❌ 8 regressions
✅ 102 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark po4tion:feat/unzipWith po4tion:feat/unzipWith Change
lodash/differenceWith 69.3 µs 223.1 µs -68.93%
lodash/intersectionBy 308 µs 443.1 µs -30.49%
lodash/intersectionWith 246.2 µs 92.1 µs ×2.7
lodash/pick 86.4 µs 251.5 µs -65.65%
es-toolkit/range 48.4 µs 39.2 µs +23.4%
lodash/range 44.1 µs 33.5 µs +31.64%
lodash/shuffle 42.9 µs 373.7 µs -88.51%
lodash/union 75.8 µs 234 µs -67.59%
lodash/unionBy 229.3 µs 385.6 µs -40.52%
lodash/xorBy 91.4 µs 375.7 µs -75.67%
lodash/zip 253.3 µs 364.6 µs -30.52%
lodash/zipWith 400 µs 264.2 µs +51.43%

src/array/unzipWith.ts Outdated Show resolved Hide resolved
src/array/unzipWith.ts Outdated Show resolved Hide resolved
src/array/unzipWith.ts Outdated Show resolved Hide resolved
src/array/unzipWith.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your awesome pull request!

@raon0211 raon0211 merged commit 834d50c into toss:main Jul 3, 2024
7 of 8 checks passed
@po4tion
Copy link
Contributor Author

po4tion commented Jul 3, 2024

Thank you for always looking at the changes in detail.
Thanks to you, I'm learning a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for unzipWith
3 participants