Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inRange): add inRange #124

Merged
merged 1 commit into from
Jul 5, 2024
Merged

feat(inRange): add inRange #124

merged 1 commit into from
Jul 5, 2024

Conversation

jgjgill
Copy link
Contributor

@jgjgill jgjgill commented Jul 3, 2024

close #97

I add the inRange function based on the discussion in the issue.

Thanks.

@jgjgill jgjgill requested a review from raon0211 as a code owner July 3, 2024 13:32
Copy link

vercel bot commented Jul 3, 2024

@jgjgill is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a175b43) to head (a4c5967).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        64    +1     
  Lines          342       349    +7     
  Branches        39        42    +3     
=========================================
+ Hits           342       349    +7     

Copy link

codspeed-hq bot commented Jul 3, 2024

CodSpeed Performance Report

Merging #124 will degrade performances by 90.54%

Comparing jgjgill:feat/inRange (a4c5967) with main (a175b43)

Summary

⚡ 13 improvements
❌ 3 regressions
✅ 100 untouched benchmarks

🆕 2 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jgjgill:feat/inRange Change
lodash 359.4 µs 49.2 µs ×7.3
lodash/differenceBy 225.3 µs 70.6 µs ×3.2
lodash/differenceWith 348.7 µs 69.2 µs ×5
es-toolkit/forEachRight 35.9 µs 379.2 µs -90.54%
lodash/forEachRight 36.3 µs 199 µs -81.77%
🆕 es-toolkit/inRange N/A 15.3 µs N/A
🆕 lodash/inRange N/A 21.7 µs N/A
lodash/intersectionWith 251.4 µs 92.3 µs ×2.7
lodash/isNil 190.7 µs 35.4 µs ×5.4
lodash/pick 251.4 µs 86.8 µs ×2.9
lodash/shuffle 195.5 µs 43 µs ×4.5
lodash/unionBy 229.9 µs 75.7 µs ×3
lodash/unionWith 369.9 µs 84.9 µs ×4.4
es-toolkit/uniqBy 16.9 ms 12.2 ms +38.99%
lodash/unzipWith 94.6 µs 251.7 µs -62.42%
lodash/xorBy 257.3 µs 91.1 µs ×2.8
lodash/xorWith 268.1 µs 106.6 µs ×2.5
lodash/zipWith 401.3 µs 261 µs +53.78%

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 494519b into toss:main Jul 5, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for inRange
3 participants