Feat(groupBy): Updated groupBy to accept string as a second argument #917
+118
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a key-generating function, callers can now pass a string as the key that they wish to group items by.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
weijunyu
changed the title
weijunyu
commented
Dec 31, 2024
| @@ -45,3 +45,21 @@ describe('groupBy/largeArray', () => { | |||
| groupByLodash(largeArray, item => item.category); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('groupBy/stringKey', () => { | |||
|
Hello, this is actually what we will support in our compatibility library. Would you add this similar to this pull request? If not, we might work on this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Instead of a key-generating function, callers can now pass a string as the key that they wish to group items by.
Rationale
In lodash,
groupByalso accepts strings as its second argument as a shorthand for getting the key to group items on.This will allow users to do a 1 for 1 replacement with lodash.groupBy.