-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update postgres images, make sure all db services have versions in them #250
Update postgres images, make sure all db services have versions in them #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with PGSQL 13 - all data was preserved, able to take down and re-up with no issues
Edit: retried with PGSQL changing "pgsql" to "pgsql12", same result
Thanks @NathanielWalmsley but the container we renamed is pgsql -> pgsql12. Probably best to try that one too. |
ab50352
to
2aa8389
Compare
rebased path as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Just a few suggestions
@@ -0,0 +1,130 @@ | |||
FROM php:8.0-fpm-buster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FROM php:8.0-fpm-alpine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already changed those to bullseye in #248
Going to alpine requires a bit more work and testing and I think I will open a new PR for that.
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ | ||
apt-transport-https \ | ||
libfreetype6-dev \ | ||
libjpeg62-turbo-dev \ | ||
libmcrypt-dev \ | ||
libpng-dev \ | ||
libxml2-dev \ | ||
libicu-dev \ | ||
libpq-dev \ | ||
gnupg2 \ | ||
nano \ | ||
vim \ | ||
wget \ | ||
openssl \ | ||
locales \ | ||
tzdata \ | ||
git \ | ||
libzip-dev \ | ||
libmemcached-dev \ | ||
zip \ | ||
netcat \ | ||
bc \ | ||
ghostscript \ | ||
graphviz \ | ||
aspell \ | ||
libldap2-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this need to be RUN apk add --no-cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related to alpine, that's going to be a separate piece of work for the php images
RUN curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \ | ||
&& curl https://packages.microsoft.com/config/debian/10/prod.list > /etc/apt/sources.list.d/mssql-release.list \ | ||
&& apt-get update && ACCEPT_EULA=Y apt-get install -y \ | ||
msodbcsql17 \ | ||
mssql-tools \ | ||
unixodbc-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \ && curl https://packages.microsoft.com/config/debian/11/prod.list > /etc/apt/sources.list.d/mssql-release.list \ && apt-get update && ACCEPT_EULA=Y apt-get install -y \ msodbcsql18 \ mssql-tools18 \ unixodbc-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already covered in #244
# Workaround to get MSSQL connection working on Debian 10 (buster) | ||
# https://emacstragic.net/2017/11/06/mssql-odbc-client-on-debian-9-stretch/ | ||
RUN wget "http://security.debian.org/debian-security/pool/updates/main/o/openssl/libssl1.0.0_1.0.1t-1+deb8u12_amd64.deb" \ | ||
&& DEBIAN_FRONTEND=noninteractive dpkg -i ./libssl1.0.0_1.0.1t-1+deb8u12_amd64.deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep that's already done in the develop
branch. see #244
Addresses #159
This requires a few steps when you are using the affected services (mysql, mssql, pgsql, mariadb):
tstop mysql
docker container rm totara_mysql57
tdocker up -d --remove-orphans mysql57
If you follow these steps the data should still be there. Of course you need to update your config.php to connect to
mysql57
instead ofmysql
.