-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cleaning #68
Fix/cleaning #68
Conversation
android/app/build.gradle
Outdated
@@ -112,14 +108,6 @@ android { | |||
abiFilters "armeabi-v7a", "x86" | |||
} | |||
} | |||
signingConfigs { | |||
release { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modifications (temp) done.
import styles from "./styles"; | ||
|
||
// https://pawelgrzybek.com/return-multiple-elements-from-a-component-with-react-16/ | ||
const Aux = props => props.children; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defined in the same file?
<Progress progress={this.props.performance.value} /> | ||
</View> | ||
); | ||
return <Progress progress={this.props.performance.value} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
import selector from "./selector"; | ||
import mapDispatchToProps from "./mapDispatchToProps"; | ||
import Link from "../../../components/typography/link/Link"; | ||
import RaceMap from "../../../components/specific/map/RaceMap"; | ||
import CollapsableDrawer from "../../../components/specific/collapsableDrawer/CollapsableDrawer"; | ||
|
||
// fix me -> remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WTF!
}; | ||
|
||
export const getIconName = (value = "") => mapping[value] || "error"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better this way!
starting point for more cleaning