Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cleaning #68

Merged
merged 7 commits into from
Oct 26, 2017
Merged

Fix/cleaning #68

merged 7 commits into from
Oct 26, 2017

Conversation

guipasmoi
Copy link
Collaborator

starting point for more cleaning

@@ -112,14 +108,6 @@ android {
abiFilters "armeabi-v7a", "x86"
}
}
signingConfigs {
release {
Copy link
Owner

@totorototo totorototo Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above.

Copy link
Owner

@totorototo totorototo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modifications (temp) done.

import styles from "./styles";

// https://pawelgrzybek.com/return-multiple-elements-from-a-component-with-react-16/
const Aux = props => props.children;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined in the same file?

<Progress progress={this.props.performance.value} />
</View>
);
return <Progress progress={this.props.performance.value} />;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import selector from "./selector";
import mapDispatchToProps from "./mapDispatchToProps";
import Link from "../../../components/typography/link/Link";
import RaceMap from "../../../components/specific/map/RaceMap";
import CollapsableDrawer from "../../../components/specific/collapsableDrawer/CollapsableDrawer";

// fix me -> remove
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF!

};

export const getIconName = (value = "") => mapping[value] || "error";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better this way!

@totorototo totorototo merged commit 05d2d7d into master Oct 26, 2017
@totorototo totorototo deleted the fix/cleaning branch January 8, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants