Add gd_string_name_from_unchecked_pystr and use it instead of doing s…

…tring-to-string-name conversion

src/godot/builtins_pyx/constructor.pyx.j2

@@ -51,13 +51,7 @@ def __cinit__(self, s=None):
     if s is None:
         self._gd_data = {{ builtin.c_name_prefix }}_new()
     elif isinstance(s, str):
-        gds = gd_string_from_unchecked_pystr(s)
-        try:
-{%   set constructor = builtin.get_constructor_from("String") %}
-            self._gd_data = {{ constructor.c_name }}(&gds)
-            return
-        finally:
-            gd_string_del(&gds)
+        self._gd_data = gd_string_name_from_unchecked_pystr(s)
     else:
         try:
 {%   set constructor = builtin.get_constructor_from("String") %}

src/godot/classes.pyx.j2

@@ -192,9 +192,7 @@ cdef object _object_call(GDExtensionObjectPtr obj, str meth, args):
         variant_args_ptrs[i] = &variant_args[i]
 
     # TODO: provide a helper for string name from Python str creation
-    cdef gd_string_t meth_gdstr = gd_string_from_unchecked_pystr(meth)
-    cdef gd_string_name_t meth_gdstrname = gd_string_name_new_from_string(&meth_gdstr)
-    gd_string_del(&meth_gdstr)
+    cdef gd_string_name_t meth_gdstrname = gd_string_name_from_unchecked_pystr(meth)
     variant_args[0] = gd_string_name_into_variant(&meth_gdstrname)
     # Into conversion steals the owneship, so no need to delete meth_gdstrname
 

src/godot/hazmat/gdapi.pxd.j2

@@ -76,6 +76,12 @@ cdef inline gd_string_t gd_string_from_pybytes(bytes cstr):
     return gdstr
 
 
+cdef inline gd_string_name_t gd_string_name_from_unchecked_pystr(object pystr):
+    cdef ssize_t buffsize
+    cdef const char *buff = PyUnicode_AsUTF8AndSize(pystr, &buffsize)
+    return gd_string_name_from_utf8_and_len(buff, buffsize)
+
+
 cdef inline gd_string_name_t gd_string_name_from_pybytes(bytes cstr):
     cdef gd_string_t gdstr = gd_string_from_pybytes(cstr)
     cdef gd_string_name_t gdstrname = gd_string_name_new_from_string(&gdstr)