Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⌨️ Input: Add ability to render as <textarea> && add placement of description #76

Merged
merged 8 commits into from
Oct 13, 2020

Conversation

ovlb
Copy link
Member

@ovlb ovlb commented Oct 8, 2020

What has been added

  • Usage of the component as <textarea>
  • Making component more flexible by allowing to place the description

How can this be tested

Added storybook stories for both cases

Additonal remarks

Tested only the surface w/ dev tools as API and ARIA properties are not really affected by this change

@ovlb ovlb added enhancement New feature or request component:input Issues regarding @tournant/input labels Oct 8, 2020
@ovlb ovlb requested a review from marcus-herrmann October 8, 2020 17:34
@ovlb
Copy link
Member Author

ovlb commented Oct 8, 2020

@marcus-herrmann 👋 I’m finally working with Vue again and was reminded of our little project.

@ovlb ovlb self-assigned this Oct 8, 2020
Comment on lines +26 to +28
>
{{ value }}
</component>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is a bit subpar. <input> has no closing tag, normally. But … it’s a Vue template, not HTML. The rendered resulting HTML is valid again. 🤷

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be worth an inline comment. Paraphrasing or linking to your very comment here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@marcus-herrmann
Copy link
Collaborator

👋 I also - hopefully - will have a little bit more time for tournant than in the last 8 or so months.

@ovlb Planning to look into this. When I check this branch out, run npm i && npm run storybook I got the following error messages:

ERROR in ./packages/breadcrumb/src/index.vue?vue&type=script&lang=js& (./node_modules/babel-loader/lib??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./packages/breadcrumb/src/index.vue?vue&type=script&lang=js&)
Module not found: Error: Can't resolve '@tournant/dynamic-anchor' in '/Users/marcusherrmann/sites/static/ui/packages/breadcrumb/src'
 @ ./packages/breadcrumb/src/index.vue?vue&type=script&lang=js& (./node_modules/babel-loader/lib??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./packages/breadcrumb/src/index.vue?vue&type=script&lang=js&) 37:0-61 40:27-48
 @ ./packages/breadcrumb/src/index.vue?vue&type=script&lang=js&
 @ ./packages/breadcrumb/src/index.vue
 @ ./packages/breadcrumb/tests/breadcrumb.stories.js
 @ ./packages sync \.stories\.js$
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js (webpack)-hot-middleware/client.js?reload=true&quiet=true

ERROR in ./packages/input/src/index.vue?vue&type=script&lang=js& (./node_modules/babel-loader/lib??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./packages/input/src/index.vue?vue&type=script&lang=js&)
Module not found: Error: Can't resolve 'uuid-browser/v4' in '/Users/marcusherrmann/sites/static/ui/packages/input/src'
 @ ./packages/input/src/index.vue?vue&type=script&lang=js& (./node_modules/babel-loader/lib??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./packages/input/src/index.vue?vue&type=script&lang=js&) 56:0-35 91:10-14
 @ ./packages/input/src/index.vue?vue&type=script&lang=js&
 @ ./packages/input/src/index.vue
 @ ./packages/input/tests/input.stories.js
 @ ./packages sync \.stories\.js$
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js (webpack)-hot-middleware/client.js?reload=true&quiet=true

@ovlb
Copy link
Member Author

ovlb commented Oct 13, 2020

@marcus-herrmann That’s good news :) I also dreamt of a project for us. But forget what it was. Maybe it’ll come back.

Regarding the error: I’ve updated some packages. Could you run yarn bootstrap in the project root? Maybe that’ll solve it.

@marcus-herrmann
Copy link
Collaborator

@ovlb Yep, that was it. Seems I have forgotten about that command, though it's stated very clearly in the readme 🤦

@ovlb
Copy link
Member Author

ovlb commented Oct 13, 2020

@marcus-herrmann Oh, I feel you, I was looking completely flabbergasted while trying to set up the project again after my brain was wiped by Python and a pandemic.

@marcus-herrmann
Copy link
Collaborator

Python and a pandemic.

<offtopic>Great band name</offtopic>

@ovlb ovlb merged commit fa24380 into master Oct 13, 2020
@ovlb ovlb deleted the input/textarea-help-placement branch October 13, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:input Issues regarding @tournant/input enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants