-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⌨️ Input: Add ability to render as <textarea>
&& add placement of description
#76
Conversation
chore: update storybook
@marcus-herrmann 👋 I’m finally working with Vue again and was reminded of our little project. |
> | ||
{{ value }} | ||
</component> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is a bit subpar. <input>
has no closing tag, normally. But … it’s a Vue template, not HTML. The rendered resulting HTML is valid again. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be worth an inline comment. Paraphrasing or linking to your very comment here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
👋 I also - hopefully - will have a little bit more time for tournant than in the last 8 or so months. @ovlb Planning to look into this. When I check this branch out, run
|
@marcus-herrmann That’s good news :) I also dreamt of a project for us. But forget what it was. Maybe it’ll come back. Regarding the error: I’ve updated some packages. Could you run |
@ovlb Yep, that was it. Seems I have forgotten about that command, though it's stated very clearly in the readme 🤦 |
@marcus-herrmann Oh, I feel you, I was looking completely flabbergasted while trying to set up the project again after my brain was wiped by Python and a pandemic. |
|
What has been added
<textarea>
How can this be tested
Added storybook stories for both cases
Additonal remarks
Tested only the surface w/ dev tools as API and ARIA properties are not really affected by this change