Refactor use of futures crate #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
futures-crates
branch
from
2faae6d to
dbcd590
Compare
|
Hm, I'm unsure whether we should really remove the |
tottoto
force-pushed
the
futures-crates
branch
from
dbcd590 to
3b04ce5
Compare
|
Fixed. |
|
http 1.0 is released, how about upgrading to http 1.0? |
That's what #348 does. Why are you asking on this PR? |
|
sorry. |
|
@getong no worries, I was just a bit confused by it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactoring.
Solution
futures_{util,core}withstd's APIs when possible.futures_core's API viafutures_utilas already used at the other places.futureswithfutures_util.futures_utildependency optional.