Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 164, pipdeptree doesn't work with python 3.11 #169

Closed
wants to merge 10 commits into from
Closed

Issue 164, pipdeptree doesn't work with python 3.11 #169

wants to merge 10 commits into from

Conversation

dqkqd
Copy link
Contributor

@dqkqd dqkqd commented Aug 17, 2022

Hi, I'm trying to fix issue #164 which makes pipdeptree does not work with python 3.11.

Since python 3.11, pip try to use importlib.metadata.Distribution instead of pkg_resources.Distribution.
https://github.com/pypa/pip/blob/e2c9c40edeb65b9d26c13a12dbe5642dc2e00fd0/src/pip/_internal/metadata/__init__.py#L45-L49

Currently there is a workaround which is set _PIP_USE_IMPORTLIB_METADATA=0 as mentioned in #164 (comment).
But I think it should be better to explicit import pkg_resources and use it.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on main branch.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds 1k lines and remove 1k. In this form is just too much. We'll need to reopen a new PR that's cleanly on top of the current main.

@gaborbernat gaborbernat closed this Sep 6, 2022
@dqkqd dqkqd deleted the issue-164 branch September 6, 2022 07:37
@dqkqd
Copy link
Contributor Author

dqkqd commented Sep 6, 2022

Sorry for the mess with git, I created a new one #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants