Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to run tox --devenv without config file #1643

Closed
hroncok opened this issue Aug 6, 2020 · 4 comments · Fixed by #1644
Closed

Allow to run tox --devenv without config file #1643

hroncok opened this issue Aug 6, 2020 · 4 comments · Fixed by #1644
Labels
feature:new something does not exist yet, but should

Comments

@hroncok
Copy link
Contributor

hroncok commented Aug 6, 2020

See #1642 (comment)

heheh I actually noticed this behaviour recently and considered it a feature (at least for tox --devenv which just works even without tox configuration)

Well, if it is useful to allow devenv without configuration, let's do that explicitly and not just with setup.cfg?
@hroncok hroncok added the feature:new something does not exist yet, but should label Aug 6, 2020
@hroncok hroncok mentioned this issue Aug 6, 2020
Merged
6 tasks
@hroncok
Copy link
Contributor Author

hroncok commented Aug 6, 2020

I've looked into it and many "set defaults" things are tightly coupled with "parse an ini config" I will prep a PR for this but it might be worth considering to uncouple those two things (I won't have time to do that).

@gaborbernat
Copy link
Member

gaborbernat commented Aug 6, 2020 •
edited
Loading

For tox 3 I don't think we'll do any major refactors/decoupling that's reserved for tox 4 on the rewrite branch. I think there's already some decoupling there.

hroncok added a commit to hroncok/tox that referenced this issue Aug 6, 2020
@hroncok
Allow to use --devenv without tox cnfig
6add777 
Fixes tox-dev#1643
hroncok added a commit to hroncok/tox that referenced this issue Aug 6, 2020
@hroncok
Allow to use --devenv without tox cnfig
bd6bf8c 
Fixes tox-dev#1643
@hroncok hroncok mentioned this issue Aug 6, 2020
Merged
6 tasks
@hroncok
Copy link
Contributor Author

hroncok commented Aug 6, 2020

Ack. Here is my PR: #1644

hroncok added a commit to hroncok/tox that referenced this issue Aug 6, 2020
@hroncok
Allow to use --devenv without tox config
23ea4fd 
Fixes tox-dev#1643
asottile pushed a commit that referenced this issue Aug 6, 2020
@hroncok
Allow to use --devenv without tox config (#1644)
8317240 
Fixes #1643
@gaborbernat
Copy link
Member

Released via https://pypi.org/project/tox/3.19.0/

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
ssbarnea pushed a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
@hroncok @ssbarnea
Allow to use --devenv without tox config (tox-dev#1644)
0b5726f 
Fixes tox-dev#1643
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature:new something does not exist yet, but should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to use --devenv without tox config hroncok/tox
2 participants
@gaborbernat @hroncok