Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various fixes related to sub-process handling #1186

Merged
merged 9 commits into from
Mar 27, 2019
Merged

various fixes related to sub-process handling #1186

merged 9 commits into from
Mar 27, 2019

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Mar 12, 2019 •
edited
Loading

Resolves #1172
Resolves #1137
Resolves #1150
Resolves #1203
Resolves #1143
Resolves #1159

@gaborbernat
Copy link
Member Author

gaborbernat commented Mar 13, 2019 •
edited
Loading

Lesson of the day: thread.join is dangerous on the main thread as it suspends signal handling (threading.Event does not), so if you want signal handling one should join with a timeout and keep re-joining 🤦‍♂️ to give a chance for the signal handler on the main thread to process.

@gaborbernat
Copy link
Member Author

gaborbernat commented Mar 13, 2019 •
edited
Loading

On windows now I believe I'm hitting https://bugs.python.org/issue21822 🤦‍♂️

hit wall

@gaborbernat gaborbernat mentioned this pull request Mar 19, 2019
Closed
@gaborbernat
Copy link
Member Author

gaborbernat commented Mar 19, 2019 •
edited
Loading

my feelings right now related to this PR and Windows
windows

oddly enough manually running the fix on Windows (from Powershell) does work...

@gaborbernat gaborbernat changed the title fix paralell runs keyboard interrupt leaves children running CTRL+C leaves sub-process children running Mar 25, 2019
@gaborbernat gaborbernat changed the title CTRL+C leaves sub-process children running various fixes Mar 26, 2019
@gaborbernat gaborbernat changed the title various fixes various fixes related to sub-process handling Mar 26, 2019
@gaborbernat gaborbernat mentioned this pull request Mar 27, 2019
Closed
@gaborbernat
Copy link
Member Author

CI passed 🍾 🎉. Probably the PR I struggled the most within this project. Threading and processes are definitely hard.

blood sacrifice

On the bright side this fixes 6 issues, and with this 3.8.0 now is ready for release. I'll do it tonight (so I can fix any potential issues arising tomorrow/Friday).

@gaborbernat gaborbernat merged commit 43d65b1 into tox-dev:master Mar 27, 2019
@gaborbernat gaborbernat deleted the parallel-kill branch March 27, 2019 15:52
@brettlangdon
Copy link

🙇

@gaborbernat
Copy link
Member Author

This is now released via 3.8.0. 🌠🍀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin left review comments

@asottile asottile asottile left review comments

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaborbernat @brettlangdon @mgedmin @asottile