feat: support vim.ui.open for GBrowse on Neovim #2322
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not uncommon for Neovim users to have netrw disabled in favor of other file explorers. When this is the case,
:GBrowse
fails. Neovim 0.10 ships with a new vim.ui.open helper method that is designed to replace this exact functionality.This PR simply preferentially uses
vim.ui.open
in Neovim 0.10+ over netrw. I have tested it with a simple:GBrowse
in a file and it appears to work well.