Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM-523] Bump morley and other deps #165

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Conversation

rvem
Copy link
Contributor

@rvem rvem commented Mar 10, 2021

Problem: We want to check whether this repo can be used with the latest
morley and new GHC version.

Solution: Bump dependencies and make required changes in the code.

Description

Related issue(s)

https://issues.serokell.io/issue/TM-523

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog unless I am sure my changes are
      not essential.

Stylistic guide (mandatory)

@rvem rvem force-pushed the rvem/tm523-morley-lts-17-3 branch 2 times, most recently from ff22a11 to 8c47d05 Compare April 13, 2021 11:26
@rvem rvem force-pushed the rvem/tm523-morley-lts-17-3 branch from 8c47d05 to d13aa35 Compare August 31, 2021 08:37
@rvem rvem requested a review from pasqu4le August 31, 2021 08:38
@rvem rvem force-pushed the rvem/tm523-morley-lts-17-3 branch 3 times, most recently from 70a942d to 64d1f08 Compare August 31, 2021 11:49
@pasqu4le
Copy link
Contributor

pasqu4le commented Aug 31, 2021

The changelog should be updated, also while the gas cost should only be updated after the next release I think the rest of the README should be updated now (particularly the instructions to deploy the contract, which are based on dead testnets).

Edit: it seems that there are also related dead links that could be fixed

Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but overall LGTM 👌

haskell/nettest/FA1_2Comparison.hs Outdated Show resolved Hide resolved
haskell/nettest/StablecoinClientTest.hs Outdated Show resolved Hide resolved
haskell/src/Stablecoin/Client/Cleveland/IO.hs Outdated Show resolved Hide resolved
haskell/src/Stablecoin/Client/Contract.hs Outdated Show resolved Hide resolved
rvem added 4 commits September 2, 2021 10:23
Problem: Florence protocol is now obsolete.

Solution: Remove all florence-based tests from the CI.
Problem: We want to check whether this repo can be used with the latest
morley and new GHC version.

Solution: Bump dependencies and make required changes in the code.
Problem: Delphi protocol is obsolete for quite a long time.
However, we still reference it in the README.

Solution: Remove all delphinet mentions and adjust README.
@rvem rvem force-pushed the rvem/tm523-morley-lts-17-3 branch from d132d76 to ec80683 Compare September 2, 2021 07:24
@rvem rvem merged commit 631eac3 into master Sep 2, 2021
@rvem rvem deleted the rvem/tm523-morley-lts-17-3 branch September 2, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants