-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TM-523] Bump morley and other deps #165
Conversation
ff22a11
to
8c47d05
Compare
8c47d05
to
d13aa35
Compare
70a942d
to
64d1f08
Compare
The changelog should be updated, also while the gas cost should only be updated after the next release I think the rest of the README should be updated now (particularly the instructions to deploy the contract, which are based on dead testnets). Edit: it seems that there are also related dead links that could be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but overall LGTM 👌
Problem: Florence protocol is now obsolete. Solution: Remove all florence-based tests from the CI.
Problem: We want to check whether this repo can be used with the latest morley and new GHC version. Solution: Bump dependencies and make required changes in the code.
Problem: Delphi protocol is obsolete for quite a long time. However, we still reference it in the README. Solution: Remove all delphinet mentions and adjust README.
d132d76
to
ec80683
Compare
Problem: We want to check whether this repo can be used with the latest
morley and new GHC version.
Solution: Bump dependencies and make required changes in the code.
Description
Related issue(s)
https://issues.serokell.io/issue/TM-523
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
not essential.
Stylistic guide (mandatory)