[TM-546] Remove edo2net tests #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: protocol 008 has become obsolete. Solution: remove tests for 008 local chain and edo2net from the CI.
rvem
reviewed
May 18, 2021
| @@ -146,8 +119,8 @@ steps: | |||
| if: *not_scheduled | |||
| depends_on: | |||
There was a problem hiding this comment.
hmm, why packaging depends on nettests? 🤔
There was a problem hiding this comment.
It's buildkite dependencies, meaning the packaging step should only run after nettests are run to ensure they pass, I assume.
rvem
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: protocol 008 has become obsolete.
Solution: remove tests for 008 local chain and edo2net from the CI.
Related issue(s)
Resolves part of TM-546
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
not essential.
Stylistic guide (mandatory)