Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove tests from CI for protocol 010 #181

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

pasqu4le
Copy link
Contributor

Description

The granada/010 protocol is no longer active on mainnet and its testnet is no longer relevant to us.

This removes the tests on CI based on said protocol

Related issue(s)

TM-603

✅ Checklist for your Merge Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
    • I updated changelog unless I am sure my changes are
      not essential.

Stylistic guide (mandatory)

Problem: The granada/010 protocol is no longer active on
mainnet and its testnet is no longer relevant to us.
However, there are still tests on CI targeting it.

Solution: Remove tests from CI for protocol granada/010.
@pasqu4le pasqu4le requested a review from rvem December 10, 2021 22:51
@pasqu4le pasqu4le self-assigned this Dec 10, 2021
@pasqu4le pasqu4le merged commit 18944ee into master Dec 13, 2021
@pasqu4le pasqu4le deleted the pasqu4le/tm603-remove-granada-from-ci branch December 13, 2021 17:24
pasqu4le added a commit that referenced this pull request Dec 16, 2021
Problem: in a previous PR (#181) network tests for protocol 010
were removed from the pipeline, however the the 'packaging' step
depended on them. This caused said step to be impossible to run.

Solution: update the dependencies of the 'packaging' CI step to
wait for protocol 011's network tests instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants