[#90] Limit minters #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gromakovsky
requested changes
Aug 20, 2020
|
Note that nettest started to fail. |
gromakovsky
approved these changes
Aug 21, 2020
Problem: Currently we do not limit the number of possible minters and thus store them in a big map. But this is not required as we won't really have more than around 12 minters. Solution: Limit the total number of minters to 12. Since the number of minters is limited, we can store them in a map instead of a bigmap. So chage the storage accordingly. Add tests to check contract won't accept more then 12 minters.
sras
force-pushed
the
sras/#90-limit-minters
branch
from
e335566 to
5a6d7fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes.
configure_minterentrypoint to see if contract already contains 12 minters, and if it does throw error "MINTER_LIMIT_REACHED" (Could probably use a better error)Related issue(s)
Resolves #90
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
not essential.
Stylistic guide (mandatory)