Merge pull request quarkusio#18321 from famod/provider-constr-warn

Remove obsolete warning about @Provider and constructor injection
tqvarnst · Jul 2, 2021 · f958533 · f958533
2 parents 1987b40 + 76d805f
commit f958533
Showing 1 changed file with 0 additions and 16 deletions.
diff --git a/...ployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java b/...ployment/src/main/java/io/quarkus/resteasy/common/deployment/ResteasyCommonProcessor.java
@@ -24,7 +24,6 @@
 import org.jboss.jandex.AnnotationTarget;
 import org.jboss.jandex.AnnotationValue;
 import org.jboss.jandex.AnnotationValue.Kind;
-import org.jboss.jandex.ClassInfo;
 import org.jboss.jandex.DotName;
 import org.jboss.jandex.FieldInfo;
 import org.jboss.jandex.IndexView;
@@ -176,7 +175,6 @@ JaxrsProvidersToRegisterBuildItem setupProviders(BuildProducer<ReflectiveClassBu
                 annotatedProviders.add(i.target().asClass().name().toString());
             }
             checkProperConfigAccessInProvider(i);
-            checkProperConstructorInProvider(i);
         }
         contributedProviders.addAll(annotatedProviders);
         Set<String> availableProviders = new HashSet<>(ServiceUtil.classNamesNamedIn(getClass().getClassLoader(),
@@ -362,15 +360,6 @@ private void checkProperConfigAccessInProvider(AnnotationInstance instance) {
         }
     }
 
-    private void checkProperConstructorInProvider(AnnotationInstance i) {
-        ClassInfo targetClass = i.target().asClass();
-        if (!targetClass.hasNoArgsConstructor()) {
-            LOGGER.warn(
-                    "Classes annotated with @Provider should have a single, no-argument constructor, otherwise dependency injection won't work properly. Offending class is "
-                            + targetClass);
-        }
-    }
-
     private boolean restJsonSupportNeeded(CombinedIndexBuildItem indexBuildItem, DotName mediaTypeAnnotation) {
         for (AnnotationInstance annotationInstance : indexBuildItem.getIndex().getAnnotations(mediaTypeAnnotation)) {
             final AnnotationValue annotationValue = annotationInstance.value();
@@ -657,9 +646,4 @@ public boolean noProducesDefaultsToAll() {
             return noProducesDefaultsToAll;
         }
     }
-
-    private enum NoMediaTypesDefault {
-        ALL,
-        JSON;
-    }
 }