Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XCVU9P spiOverJtag bitfile with SPIx8 support #296

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

barbedo
Copy link
Contributor

@barbedo barbedo commented Jan 21, 2023

Refer to #293.

@trabucayre
Copy link
Owner

LGTM.
Just a remark: why updating xc7a100t's bitstream? Since modifications are conditioned by define the behaviour remains the same for all others devices?

@barbedo
Copy link
Contributor Author

barbedo commented Jan 23, 2023

Thanks!

I've regenerated and tested the Arty A7 100T bitfile to verify that I didn't break the logic outside the define.

I've included it in the commit just to "prove" that it still works. The behavior is exactly the same as the previous one.

If you don't want this binary in the master's history, I'll remove it.

@trabucayre
Copy link
Owner

In fact I try, as much as possible, to limit remove/update about spiOverJtag, to avoid increasing repository size (it's why some bitstream are uncompressed).
Discarding this file to this commit requires:

git rm thefile
git commit --amend
git push -f

As you want. If you prefer not to try these commands: I will apply with this bitstream.

@barbedo barbedo force-pushed the vcu118-flash-spi-over-jtag branch from 19fdd2f to 29d2264 Compare January 24, 2023 09:27
@barbedo
Copy link
Contributor Author

barbedo commented Jan 24, 2023

I completely agree with the concern over the repo size impact.

I've just removed the Arty's bitstream.

@trabucayre trabucayre merged commit ab7365b into trabucayre:master Jan 24, 2023
@trabucayre
Copy link
Owner

Applied thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants