Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events for critical setters #210

Merged
merged 7 commits into from
Jul 22, 2021
Merged

Add events for critical setters #210

merged 7 commits into from
Jul 22, 2021

Conversation

OsmanBran
Copy link
Contributor

@OsmanBran OsmanBran commented Jul 21, 2021 •
edited
Loading

Motivation

code-423n4/2021-06-tracer-findings#64

Changes

  • Add events for all setters in TracerPerpetualSwaps.sol
  • Add unit tests for each event

@OsmanBran OsmanBran requested review from CalabashSquash and removed request for CalabashSquash July 21, 2021 03:48
@OsmanBran OsmanBran marked this pull request as ready for review July 22, 2021 02:12
kumar-ish
kumar-ish approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@kumar-ish kumar-ish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

@OsmanBran OsmanBran merged commit 6bb8114 into contracts-v2 Jul 22, 2021
@OsmanBran OsmanBran deleted the emit-events branch July 22, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumar-ish kumar-ish kumar-ish approved these changes

@CalabashSquash CalabashSquash CalabashSquash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OsmanBran @CalabashSquash @kumar-ish