-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Localisation manager filter. #922
base: 7
Are you sure you want to change the base?
ENH: Localisation manager filter. #922
Conversation
Looks good to me. Generally the locales list isn't large enough that a search is required, but it's no harm to have it working. :) |
bf62b3b
to
1159c29
Compare
FYI: Squashed commits. |
Merge at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks fairly boilerplate though - I wonder if there's a case here for an enhancement to GridFieldFilterHeader
to automate these changes?
i.e. update GridFieldFilterHeader
so that if the list is not DataList
but the data class is a DataObject
, automatically use a BasicSearchContext
(probably basically this identical code, but in framework)
Have created silverstripe/silverstripe-framework#11575 as per your recommendation @GuySartorelli . cc: @tractorcow |
Description
Enables filtering capability in the localisation manager. This filter wasn't present because pre CMS 5 such feature was not supported. With CMS 5 it's possible so we should enable it.
Manual testing steps
Issues
#924
Pull request checklist