Upgrade golangci-lint version to v1.31

traefik · Sep 17, 2020 · 0afa0f8 · 0afa0f8
1 parent a0f82a5
commit 0afa0f8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/.golangci.toml b/.golangci.toml
@@ -46,7 +46,6 @@
     "noctx", # Too strict
     "exhaustive", # Too strict
     "nlreturn", # Too strict
-    "exportloopref", # Too strict
   ]
 
 [issues]

diff --git a/Dockerfile b/Dockerfile
@@ -21,7 +21,7 @@ WORKDIR /go/src/github.com/traefik/mesh
 RUN curl -sfL https://install.goreleaser.com/github.com/goreleaser/goreleaser.sh | sh
 
 # Download golangci-lint binary to bin folder in $GOPATH
-RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.30.0
+RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.31.0
 
 ENV GO111MODULE on
 COPY go.mod go.sum ./

diff --git a/pkg/dns/dns.go b/pkg/dns/dns.go
@@ -563,7 +563,7 @@ func addStubDomain(config, blockHeader, blockTrailer, domain, clusterDomain, tra
 
 	stubDomain := fmt.Sprintf(stubDomainFormat,
 		clusterDomain,
-		strings.Replace(clusterDomain, ".", "\\.", -1),
+		strings.ReplaceAll(clusterDomain, ".", "\\."),
 		traefikMeshNamespace,
 		blockHeader,
 		blockTrailer,

diff --git a/pkg/topology/builder.go b/pkg/topology/builder.go
@@ -554,7 +554,9 @@ func buildHTTPRouteGroupMatches(ttMatches []string, httpRouteGroupMatches []spec
 			found = match.Name == name
 
 			if found {
+				match := match
 				httpMatches = append(httpMatches, &match)
+
 				break
 			}
 		}