Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup API endpoints #764

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Cleanup API endpoints #764

merged 1 commit into from
Oct 15, 2020

Conversation

jspdown
Copy link
Contributor

@jspdown jspdown commented Oct 14, 2020

What does this PR do?

This PR:

  • Removes the /api/status/nodes endpoint
  • Removes the /api/status/nodes/<id>/configuration endpoint
  • Renames the /api/status/readiness endpoint into /api/ready
  • Renames the /api/configuration/current endpoint into /api/configuration
  • Renames the /api/topology/current endpoint into /api/topology

Fixes #749

How to test it

  • make test
  • Install Traefik Mesh on a cluster and play with the API

@jspdown jspdown added this to the next milestone Oct 14, 2020
@jspdown jspdown requested a review from kevinpollet October 14, 2020 14:22
kevinpollet
kevinpollet approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinpollet kevinpollet changed the title API endpoint cleanup Cleanup API endpoints Oct 15, 2020
@traefiker traefiker merged commit 996dd9b into traefik:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

Assignees
No one assigned
Labels
area/api kind/enhancement a new or improved feature.
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Rework the API endpoints to be more restful
3 participants
@jspdown @kevinpollet @traefiker